I’m a big believer of blackhorn209 powder. It’s essentially a smokeless powders for muzzleloaders. Cleanest powder I’ve found so far, and shelf life is pretty long. It’s common enough that I even picked up another pound from Walmart of all places a few weeks back.
Most other black powders are extremely dirty and corrosive. I had a cheapo muzzleloader about 14 years ago that I used pyrodex in. After not cleaning it a few week or so after shooting it, it basically locked up from rust. I had to throw it out after a while.

For bullets, I’ve had great luck with Barnes T-EZ.